-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5395] improvment(hive-catalog,iceberg): Set configuration hive.metastore.sasl.enabled
automatically when kerberos is enabled.
#5396
Conversation
…rberos is enabled.
Not all users use |
Do you modify the Hive catalog, too? Maybe we should consider Paimon and Hudi. |
Okay, I will hang this PR temporarily and move forward it if we can have a better solution. currently, I will add |
Another solution is that we make the configuration |
All is ok for me. Just remind that we need to consider the case that I mentioned. |
I found that #5039 is unrelated to the issue here, it that the right issue? |
hive.metastore.sasl.enabled
automatically when kerberos is enabled.hive.metastore.sasl.enabled
automatically when kerberos is enabled.
Please also update the PR description. |
I would suggest to update the doc instead of hardcode the configuration here. |
Yeah, It's acceptable to me and the document has been added by #5324 by the way. |
Close this PR temporarily as it has been partially fixed by #5324. |
What changes were proposed in this pull request?
Automatically set hive.metastore.sasl.enabled to true If Kerberos is enabled.
Why are the changes needed?
Users will not need to set this value explicitly.
Fix: #5395
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Existing ITs.