Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5395] improvment(hive-catalog,iceberg): Set configuration hive.metastore.sasl.enabled automatically when kerberos is enabled. #5396

Closed
wants to merge 1 commit into from

Conversation

yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Oct 31, 2024

What changes were proposed in this pull request?

Automatically set hive.metastore.sasl.enabled to true If Kerberos is enabled.

Why are the changes needed?

Users will not need to set this value explicitly.

Fix: #5395

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Existing ITs.

@yuqi1129 yuqi1129 self-assigned this Oct 31, 2024
@jerqi
Copy link
Collaborator

jerqi commented Oct 31, 2024

@jerqi
Copy link
Collaborator

jerqi commented Oct 31, 2024

Do you modify the Hive catalog, too? Maybe we should consider Paimon and Hudi.

@yuqi1129
Copy link
Contributor Author

Not all users use sasl. You can see stackoverflow.com/questions/11347304/security-authentication-ssl-vs-sasl

Okay, I will hang this PR temporarily and move forward it if we can have a better solution. currently, I will add hive.metastore.sasl.enabled to the document to remind users.

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Oct 31, 2024

Not all users use sasl. You can see stackoverflow.com/questions/11347304/security-authentication-ssl-vs-sasl

Okay, I will hang this PR temporarily and move forward it if we can have a better solution. currently, I will add hive.metastore.sasl.enabled to the document to remind users.

Another solution is that we make the configuration hive.metastore.sasl.enabled as true if Kerberos is enabled and tell the users explicitly the default protocol is SASL, Users can overwrite this configuration.

@jerqi
Copy link
Collaborator

jerqi commented Oct 31, 2024

Not all users use sasl. You can see stackoverflow.com/questions/11347304/security-authentication-ssl-vs-sasl

Okay, I will hang this PR temporarily and move forward it if we can have a better solution. currently, I will add hive.metastore.sasl.enabled to the document to remind users.

Another solution is that we make the configuration hive.metastore.sasl.enabled as true if Kerberos is enabled and tell the users explicitly the default protocol is SASL, Users can overwrite this configuration.

All is ok for me. Just remind that we need to consider the case that I mentioned.

@jerryshao
Copy link
Contributor

I found that #5039 is unrelated to the issue here, it that the right issue?

@yuqi1129 yuqi1129 changed the title [#5039] improvment(hive-catalog,iceberg): Set configuration hive.metastore.sasl.enabled automatically when kerberos is enabled. [#5395] improvment(hive-catalog,iceberg): Set configuration hive.metastore.sasl.enabled automatically when kerberos is enabled. Oct 31, 2024
@yuqi1129
Copy link
Contributor Author

I found that #5039 is unrelated to the issue here, it that the right issue?

I have correct the issue link and the right is #5395.

@jerryshao
Copy link
Contributor

Please also update the PR description.

@jerryshao
Copy link
Contributor

I would suggest to update the doc instead of hardcode the configuration here.

@yuqi1129
Copy link
Contributor Author

I would suggest to update the doc instead of hardcode the configuration here.

Yeah, It's acceptable to me and the document has been added by #5324 by the way.

@yuqi1129
Copy link
Contributor Author

Close this PR temporarily as it has been partially fixed by #5324.

@yuqi1129 yuqi1129 closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Optimization configuration items when connection to kerberized Hive
3 participants